Re: [PATCH v2 2/3] spi: atmel: Prevent false timeouts on long transfers

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Mark,

broonie@xxxxxxxxxx wrote on Wed, 21 Jun 2023 15:59:34 +0100:

> On Mon, Jun 19, 2023 at 05:53:48PM +0200, Miquel Raynal wrote:
> > A slow SPI bus clocks at ~20MHz, which means it would transfer about
> > 2500 bytes per second with a single data line. Big transfers, like when
> > dealing with flashes can easily reach a few MiB. The current DMA timeout
> > is set to 1 second, which means any working transfer of about 4MiB will
> > always be cancelled.  
> 
> This breaks the build:
> 
> /build/stage/linux/drivers/spi/spi-atmel.c: In function ‘atmel_spi_one_transfer’
> :
> /build/stage/linux/drivers/spi/spi-atmel.c:1338:76: error: ‘master’ undeclared (
> first use in this function)
>  1338 |                 dma_timeout = msecs_to_jiffies(spi_controller_xfer_timeo
> ut(master, xfer));
>       |                                                                         
>    ^~~~~~
> /build/stage/linux/drivers/spi/spi-atmel.c:1338:76: note: each undeclared identi
> fier is reported only once for each function it appears in

I am testing on a customer board which currently runs on 6.1, I lacked
398b6b310ec8 ("spi: atmel: switch to use modern name"). I'll send an update.

Thanks,
Miquèl