On Fri, May 26, 2023 at 02:25:28PM +0800, William Qiu wrote:
> if (of_device_is_compatible(pdev->dev.of_node, "starfive,jh7110-qspi")) {
> + qspi_ahb = devm_clk_get(dev, "qspi-ahb");
> + if (IS_ERR(qspi_ahb)) {
> + dev_err(dev, "Cannot claim QSPI_AHB clock.\n");
> + ret = PTR_ERR(qspi_ahb);
> + return ret;
> + }
> +
> + ret = clk_prepare_enable(qspi_ahb);
> + if (ret) {
> + dev_err(dev, "Cannot enable QSPI AHB clock.\n");
> + goto probe_clk_failed;
> + }
Nothing ever disables or unprepares this clock as far as I can tell?
Perhaps also consider using the clk_bulk_ APIs.
Attachment:
signature.asc
Description: PGP signature
