Re: [PATCH v5 4/4] spi: spidev_test Add three missing spi mode bits

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Sat, May 20, 2023 at 10:09 PM Boerge Struempfel
<boerge.struempfel@xxxxxxxxx> wrote:
>
> Added the three missing spi mode bits SPI_3WIRE_HIZ, SPI_RX_CPHA_FLIP,
> and SPI_MOSI_IDLE_LOW. Due to the length of the new options, the
> indentation of the options in the help message was also adjusted for all
> other options.

Actually since you are touching all of them in the user-visible
output, you may also reshuffle them to be grouped logically. I'm not
sure if the switch-case ordering would be nice to have shuffled as
well. If so, in this case it might be better to have it as a
preparatory patch before you adding new options (and hence take care
of indentation in the first patch). That said, just think about it,
I'm not insisting.


-- 
With Best Regards,
Andy Shevchenko