Sat, May 13, 2023 at 05:26:53AM -0700, Sukrut Bellary kirjoitti: > smatch warning - > drivers/spi/spi-pic32.c:634 pic32_spi_dma_prep() warn: missing error code 'ret' > > Currently in case of pic32_spi_dma_config() failure, SUCCESS is returned. > Capture and return the error code in the failure path. The comment above the pic32_spi_dma_config() call on the caller side suggests that DMA is optional. With that in mind the current code won't prevent us from using the driver in PIO mode. > This is based on static analysis only. Compilation tested. That's why I think it's incorrect fix. You need to fix smatch. -- With Best Regards, Andy Shevchenko
Re: [PATCH] spi:pic32: Fix missing error code 'ret' in the failure path
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] spi:pic32: Fix missing error code 'ret' in the failure path
- From: andy.shevchenko@xxxxxxxxx
- Date: Sat, 13 May 2023 18:14:01 +0300
- Cc: Mark Brown <broonie@xxxxxxxxxx>, linux-spi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <20230513122653.45226-1-sukrut.bellary@linux.com>
- References: <20230513122653.45226-1-sukrut.bellary@linux.com>
- References:
- [PATCH] spi:pic32: Fix missing error code 'ret' in the failure path
- From: Sukrut Bellary
- [PATCH] spi:pic32: Fix missing error code 'ret' in the failure path
- Prev by Date: [PATCH] spi:pic32: Fix missing error code 'ret' in the failure path
- Next by Date: [PATCH] spi: MAINTAINERS: drop Krzysztof Kozlowski from Samsung SPI
- Previous by thread: [PATCH] spi:pic32: Fix missing error code 'ret' in the failure path
- Next by thread: [PATCH] spi: MAINTAINERS: drop Krzysztof Kozlowski from Samsung SPI
- Index(es):
 |