Re: [PATCH] spi: bcm63xx: use macro DEFINE_SIMPLE_DEV_PM_OPS

["Gole, Dhruva" <d-gole@xxxxxx>]

Hi Jonas,

On 4/25/2023 4:55 PM, Jonas Gorski wrote:
> On Mon, 24 Apr 2023 at 12:25, Dhruva Gole <d-gole@xxxxxx> wrote:
>> Using this macro makes the code more readable.
>> It also inits the members of dev_pm_ops in the following manner
>> without us explicitly needing to:
>>
>> .suspend = bcm63xx_spi_suspend, \
>> .resume = bcm63xx_spi_resume, \
>> .freeze = bcm63xx_spi_suspend, \
>> .thaw = bcm63xx_spi_resume, \
>> .poweroff = bcm63xx_spi_suspend, \
>> .restore = bcm63xx_spi_resume
>>
>> Signed-off-by: Dhruva Gole <d-gole@xxxxxx>
> I think this should have an appropriate Fixes tag as it will fix a
> build warning when building with !CONFIG_PM after applying the
> previous patch.


You mean these build issues that have been pointed here?

https://lore.kernel.org/all/8edb48ee-55a3-4cc2-9c81-514ec867b35c@xxxxxxxxxxxx/

So I should add a fixes "spi: bcm63xx: remove PM_SLEEP based conditional compilation"

corresponding fixes tag?

>
> Regards
> Jonas

-- 
Regards,
Dhruva Gole <d-gole@xxxxxx>