Re: [PATCH] drivers: spi: sunxi: Enable irq after the initialization is done

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 25, 2023 at 08:22:16AM +0800, qianfan wrote:
> 在 2023/4/24 19:46, Mark Brown 写道:
> > On Sun, Apr 23, 2023 at 10:30:56AM +0800, qianfanguijin@xxxxxxx wrote:

> > > +	enable_irq(irq);

> > The usual approach would be to move the requesting of the interrupt
> > later.  Why do this instead?

> Nothing special, this way does not change the goto logic.

It would be better to restructure the code, enable_irq() is a fairly
specialist function and should only be used if it is really needed -
it's a big warning sign to see it used.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux