On 4/24/23 13:54, Mark Brown wrote: > On Sun, Apr 23, 2023 at 02:11:54PM +0800, Yingsha Xu wrote: >> Smatch complains that: >> dw_spi_debugfs_init() warn: 'dws->debugfs' is an error pointer >> or valid >> >> Debugfs checks are generally not supposed to be checked for errors >> and it is not necessary here. >> >> Just delete the dead code. > > This is very much a question of taste with a range of use cases > available. No. https://lkml.iu.edu/hypermail/linux/kernel/1901.2/05993.html We can do things with the debug information without filesystem enabled.
Re: [PATCH] spi: remove return value check of debugfs_create_dir()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] spi: remove return value check of debugfs_create_dir()
- From: Peter Enderborg <peter.enderborg@xxxxxxxx>
- Date: Mon, 24 Apr 2023 14:20:45 +0200
- Cc: Serge Semin <fancer.lancer@xxxxxxxxx>, linux-spi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <eb3c6aa6-6820-4e94-8eb0-5abd3b627fcc@sirena.org.uk>
- References: <20230423061155.2540-1-ysxu@hust.edu.cn> <eb3c6aa6-6820-4e94-8eb0-5abd3b627fcc@sirena.org.uk>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.10.0
- Follow-Ups:
- Re: [PATCH] spi: remove return value check of debugfs_create_dir()
- From: Mark Brown
- Re: [PATCH] spi: remove return value check of debugfs_create_dir()
- References:
- [PATCH] spi: remove return value check of debugfs_create_dir()
- From: Yingsha Xu
- Re: [PATCH] spi: remove return value check of debugfs_create_dir()
- From: Mark Brown
- [PATCH] spi: remove return value check of debugfs_create_dir()
- Prev by Date: Re: (subset) [Patch V10 0/3] Tegra TPM driver with HW flow control
- Next by Date: Patchwork summary for: spi-devel-general
- Previous by thread: Re: [PATCH] spi: remove return value check of debugfs_create_dir()
- Next by thread: Re: [PATCH] spi: remove return value check of debugfs_create_dir()
- Index(es):
 |