Re: [PATCH v7 1/6] usb: Add support for Intel LJCA device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 25, 2023 at 11:27:03PM +0100, Greg Kroah-Hartman wrote:
> On Sat, Mar 25, 2023 at 11:47:06PM +0800, Ye Xiang wrote:
> > +static void ljca_aux_release(struct device *dev) {}
> 
> Sorry, but creating an empty release function just to shut the kernel up
> is NOT how to properly do this, you all know better.  This is totally
> broken.  The kernel was telling you what you had to do, don't think that
> you are being smarter than it by doing this, otherwise we would have
> never had the kernel spit out that error in the first place, right?
Got it. Will use the release callback to free memory used by the auxiliary
device instead.
> 
> Now I will ask you to follow the proper Intel kernel review rules and
> get proper approval for the patchset before submitting it to us again,
> as basic things like this are not supposed to be caught by us, but by
> your internal review process first.
Thanks. I will get approval on Intel's internal review first before sending
the next version out for review.

--
Thanks
Ye Xiang




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux