Hello Conor, On Fri, Mar 03, 2023 at 05:46:11PM +0000, Conor Dooley wrote: > On Fri, Mar 03, 2023 at 06:20:21PM +0100, Uwe Kleine-König wrote: > > The .remove() callback for a platform driver returns an int which makes > > many driver authors wrongly assume it's possible to do error handling by > > returning an error code. However the value returned is (mostly) ignored > > and this typically results in resource leaks. To improve here there is a > > quest to make the remove callback return void. In the first step of this > > quest all drivers are converted to .remove_new() which already returns > > void. > > > > Trivially convert this driver from always returning zero in the remove > > callback to the void returning variant. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > This one landed in my mailbox too, so: > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> I have ~2000 of such patches pending in my tree that wait for submission. If you want a Cc: for each of them, just tell me :-) Best regards and thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
