Re: [PATCH] spi: cadence-quadspi: Fix cancel the indirect read mask

[Dhruva Gole <d-gole@xxxxxx>]

Hi Hongbin,

On 22/02/23 14:51, Hongbin Ji wrote:
> This is to cancel the indirect read transfer process,
> so should be use CQSPI_REG_INDIRECTRD_CANCEL_MASK

Good catch!
Both macros expand to BIT(1) so probably we did not face any issues so
far.

> Signed-off-by: Hongbin Ji <jhb_ee@xxxxxxx>
> ---

Reviewed-by: Dhruva Gole <d-gole@xxxxxx>

>   drivers/spi/spi-cadence-quadspi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
> index 676313e1bdad..967cb8ec0eec 100644
> --- a/drivers/spi/spi-cadence-quadspi.c
> +++ b/drivers/spi/spi-cadence-quadspi.c
> @@ -766,7 +766,7 @@ static int cqspi_indirect_read_execute(struct cqspi_flash_pdata *f_pdata,
>   	writel(0, reg_base + CQSPI_REG_IRQMASK);
>   
>   	/* Cancel the indirect read */
> -	writel(CQSPI_REG_INDIRECTWR_CANCEL_MASK,
> +	writel(CQSPI_REG_INDIRECTRD_CANCEL_MASK,
>   	       reg_base + CQSPI_REG_INDIRECTRD);
>   	return ret;
>   }

--
Thanks and Regards,
Dhruva Gole