Re: [PATCH] spi: Remove extra/duplicate constant from expression

[Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>]

Le 11/02/2023 à 10:59, Deepak R Varma a écrit :
> Constant SPI_TX_OCTAL is included twice while building the controller
> mode bits. Remove the extra constant.
> Issue identified using doublebitand.cocci Coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <drv-asAA5fHt7EIAvxtiuMwx3w@xxxxxxxxxxxxxxxx>
> ---
>   drivers/spi/spi-sn-f-ospi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-sn-f-ospi.c b/drivers/spi/spi-sn-f-ospi.c
> index 348c6e1edd38..19284d6914fc 100644
> --- a/drivers/spi/spi-sn-f-ospi.c
> +++ b/drivers/spi/spi-sn-f-ospi.c
> @@ -611,7 +611,7 @@ static int f_ospi_probe(struct platform_device *pdev)
>   		return -ENOMEM;
>   
>   	ctlr->mode_bits = SPI_TX_DUAL | SPI_TX_QUAD | SPI_TX_OCTAL
> -		| SPI_RX_DUAL | SPI_RX_QUAD | SPI_TX_OCTAL
> +		| SPI_RX_DUAL | SPI_RX_QUAD

Or maybe s/SPI_TX_OCTAL/SPI_RX_OCTAL/ ?

CJ

>   		| SPI_MODE_0 | SPI_MODE_1 | SPI_LSB_FIRST;
>   	ctlr->mem_ops = &f_ospi_mem_ops;
>   	ctlr->bus_num = -1;