Re: [PATCH v3 01/13] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v3 01/13] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call
- From: Mark Brown <broonie@xxxxxxxxxx>
- Date: Thu, 9 Feb 2023 14:30:29 +0000
- Cc: miquel.raynal@xxxxxxxxxxx, richard@xxxxxx, vigneshr@xxxxxx, jic23@xxxxxxxxxx, tudor.ambarus@xxxxxxxxxxxxx, pratyush@xxxxxxxxxx, sanju.mehta@xxxxxxx, chin-ting_kuo@xxxxxxxxxxxxxx, clg@xxxxxxxx, kdasu.kdev@xxxxxxxxx, f.fainelli@xxxxxxxxx, rjui@xxxxxxxxxxxx, sbranden@xxxxxxxxxxxx, eajames@xxxxxxxxxxxxx, olteanv@xxxxxxxxx, han.xu@xxxxxxx, john.garry@xxxxxxxxxx, shawnguo@xxxxxxxxxx, s.hauer@xxxxxxxxxxxxxx, narmstrong@xxxxxxxxxxxx, khilman@xxxxxxxxxxxx, matthias.bgg@xxxxxxxxx, haibo.chen@xxxxxxx, linus.walleij@xxxxxxxxxx, daniel@xxxxxxxxxx, haojian.zhuang@xxxxxxxxx, robert.jarzmik@xxxxxxx, agross@xxxxxxxxxx, bjorn.andersson@xxxxxxxxxx, heiko@xxxxxxxxx, krzysztof.kozlowski@xxxxxxxxxx, andi@xxxxxxxxxxx, mcoquelin.stm32@xxxxxxxxx, alexandre.torgue@xxxxxxxxxxx, wens@xxxxxxxx, jernej.skrabec@xxxxxxxxx, samuel@xxxxxxxxxxxx, masahisa.kojima@xxxxxxxxxx, jaswinder.singh@xxxxxxxxxx, rostedt@xxxxxxxxxxx, mingo@xxxxxxxxxx, l.stelmach@xxxxxxxxxxx, davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx, pabeni@xxxxxxxxxx, alex.aring@xxxxxxxxx, stefan@xxxxxxxxxxxxxxxxxx, kvalo@xxxxxxxxxx, git@xxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, joel@xxxxxxxxx, andrew@xxxxxxxx, radu_nicolae.pirea@xxxxxx, nicolas.ferre@xxxxxxxxxxxxx, alexandre.belloni@xxxxxxxxxxx, claudiu.beznea@xxxxxxxxxxxxx, bcm-kernel-feedback-list@xxxxxxxxxxxx, fancer.lancer@xxxxxxxxx, kernel@xxxxxxxxxxxxxx, festevam@xxxxxxxxx, linux-imx@xxxxxxx, jbrunet@xxxxxxxxxxxx, martin.blumenstingl@xxxxxxxxxxxxxx, avifishman70@xxxxxxxxx, tmaimon77@xxxxxxxxx, tali.perry1@xxxxxxxxx, venture@xxxxxxxxxx, yuenn@xxxxxxxxxx, benjaminfair@xxxxxxxxxx, yogeshgaur.83@xxxxxxxxx, konrad.dybcio@xxxxxxxxxxxxxx, alim.akhtar@xxxxxxxxxxx, ldewangan@xxxxxxxxxx, thierry.reding@xxxxxxxxx, jonathanh@xxxxxxxxxx, michal.simek@xxxxxxx, linux-aspeed@xxxxxxxxxxxxxxxx, openbmc@xxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-rockchip@xxxxxxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, linux-sunxi@xxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-wpan@xxxxxxxxxxxxxxx, libertas-dev@xxxxxxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, lars@xxxxxxxxxx, Michael.Hennerich@xxxxxxxxxx, linux-iio@xxxxxxxxxxxxxxx, michael@xxxxxxxx, palmer@xxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, amitrkcian2002@xxxxxxxxx, Dhruva Gole <d-gole@xxxxxx>, Patrice Chotard <patrice.chotard@xxxxxxxxxxx>, William Zhang <william.zhang@xxxxxxxxxxxx>
- In-reply-to: <20230202152258.512973-2-amit.kumar-mahapatra@amd.com>
- References: <20230202152258.512973-1-amit.kumar-mahapatra@amd.com> <20230202152258.512973-2-amit.kumar-mahapatra@amd.com>
On Thu, Feb 02, 2023 at 08:52:46PM +0530, Amit Kumar Mahapatra wrote:
> Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod
> members of struct spi_device to be an array. But changing the type of these
> members to array would break the spi driver functionality. To make the
> transition smoother introduced four new APIs to get/set the
This break an arm multi_v7_defconfig build:
/build/stage/linux/drivers/spi/spi-pl022.c: In function ‘pl022_transfer_one_message’:
/build/stage/linux/drivers/spi/spi-pl022.c:1592:31: error: ‘struct spi_message’ has no member named ‘spi_get_csgpiod’
1592 | pl022->cur_gpiod = msg->spi_get_csgpiod(spi, 0);
| ^~
/build/stage/linux/drivers/spi/spi-pl022.c:1592:49: error: ‘spi’ undeclared (first use in this function)
1592 | pl022->cur_gpiod = msg->spi_get_csgpiod(spi, 0);
| ^~~
/build/stage/linux/drivers/spi/spi-pl022.c:1592:49: note: each undeclared identifier is reported only once for each function it appears in
Attachment:
signature.asc
Description: PGP signature
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|