On Thu, Jan 19, 2023, at 04:39, Brad Larson wrote:
>
> +extern unsigned int sdhci_timeout_val;
> +
This declaration should not be in the .c file, and I don't think
there should be a global variable with this overly generic name either.
Arnd
Re: [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset
- From: "Arnd Bergmann" <arnd@xxxxxxxx>
- Date: Thu, 19 Jan 2023 09:57:20 +0100
- Cc: linux-kernel@xxxxxxxxxxxxxxx, "linux-mmc @ vger . kernel . org" <linux-mmc@xxxxxxxxxxxxxxx>, linux-spi@xxxxxxxxxxxxxxx, adrian.hunter@xxxxxxxxx, alcooperx@xxxxxxxxx, "Andy Shevchenko" <andy.shevchenko@xxxxxxxxx>, blarson@xxxxxxx, brendan.higgins@xxxxxxxxx, "Brian Norris" <briannorris@xxxxxxxxxxxx>, brijeshkumar.singh@xxxxxxx, "Catalin Marinas" <catalin.marinas@xxxxxxx>, "David Gow" <davidgow@xxxxxxxxxx>, gsomlo@xxxxxxxxx, gerg@xxxxxxxxxxxxxx, "Krzysztof Kozlowski" <krzk@xxxxxxxxxx>, krzysztof.kozlowski+dt@xxxxxxxxxx, "Lee Jones" <lee@xxxxxxxxxx>, "Lee Jones" <lee.jones@xxxxxxxxxx>, "Mark Brown" <broonie@xxxxxxxxxx>, yamada.masahiro@xxxxxxxxxxxxx, "Philipp Zabel" <p.zabel@xxxxxxxxxxxxxx>, piotrs@xxxxxxxxxxx, p.yadav@xxxxxx, "Randy Dunlap" <rdunlap@xxxxxxxxxxxxx>, "Rob Herring" <robh+dt@xxxxxxxxxx>, "Samuel Holland" <samuel@xxxxxxxxxxxx>, "Serge Semin" <fancer.lancer@xxxxxxxxx>, skhan@xxxxxxxxxxxxxxxxxxx, suravee.suthikulpanit@xxxxxxx, thomas.lendacky@xxxxxxx, "Tony Huang" <tonyhuang.sunplus@xxxxxxxxx>, "Ulf Hansson" <ulf.hansson@xxxxxxxxxx>, vaishnav.a@xxxxxx, "Will Deacon" <will@xxxxxxxxxx>, devicetree@xxxxxxxxxxxxxxx
- Feedback-id: i56a14606:Fastmail
- In-reply-to: <20230119033918.44117-15-blarson@amd.com>
- References: <20230119033918.44117-1-blarson@amd.com> <20230119033918.44117-15-blarson@amd.com>
- User-agent: Cyrus-JMAP/3.9.0-alpha0-85-gd6d859e0cf-fm-20230116.001-gd6d859e0
- Follow-Ups:
- Re: [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset
- From: Brad Larson
- Re: [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset
- References:
- [PATCH v9 00/15] Support AMD Pensando Elba SoC
- From: Brad Larson
- [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset
- From: Brad Larson
- [PATCH v9 00/15] Support AMD Pensando Elba SoC
- Prev by Date: Re: [PATCH v9 06/15] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando System Resource chip
- Next by Date: Re: [PATCH v9 15/15] spi: pensando-sr: Add AMD Pensando SoC System Resource
- Previous by thread: [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset
- Next by thread: Re: [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset
- Index(es):
 |