Re: [PATCH 1/2] spi: dt-bindings: spi-fsl-qspi: add optional sampling-delay

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 18/01/2023 09:01, Michael Walle wrote:
> From: "han.xu" <han.xu@xxxxxxx>
> 
> Hi,
> 
>>>> unfortunately, the rx-sample-delay-ns property does not fit here, as we 
>>>> can only delay
>>>> the sampling point between zero and three "half cycles" (or edges), not 
>>>> by an arbitrary
>>>> number of nanoseconds.
>>>
>>> Why this is a problem for FSL but not for other platforms having exactly
>>> the same constraints/property?
>>
>> Please use the common delay in DT and calculate to half cycle in driver, we have
>> the similar discussion before for fspi controller delay settings.
> 
> Do you mean [1]? There my suggestion was to use a -degrees property (because
> it doesn't depend on the frequency). There wasn't any follow-up, or did I miss
> something?
> 
> -michael
> 
> [1] https://lore.kernel.org/linux-spi/62f113a0cdb0d58bf04ab0b274912eb7@xxxxxxxx/

I think the patch using existing ns property (and calculating cycles or
phase shift or whatever was needed) was merged. In such case please go
the same way.

Best regards,
Krzysztof