Re: [PATCH 1/2] spi: dt-bindings: spi-fsl-qspi: add optional sampling-delay

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

unfortunately, the rx-sample-delay-ns property does not fit here, as we can only delay the sampling point between zero and three "half cycles" (or edges), not by an arbitrary
number of nanoseconds.

Regarding the bot message, I do not understand what is wrong in my patch. I found similar property descriptions in other files and also in the official doc [1] there is an equal
(to me) example under "clock-frequency", if I am not missing something.

Thank you for the review!

Best regards,
Mario

[1] https://docs.kernel.org/devicetree/bindings/writing-schema.html

On 2023-01-17 15:10, Rob Herring wrote:
On Mon, Jan 16, 2023 at 12:50:49PM +0100, Mario Kicherer wrote:
Add optional sampling-delay property to delay the internal sampling point for
incoming data.

Signed-off-by: Mario Kicherer <dev@xxxxxxxxxxxx>
---
Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml b/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
index e58644558412..7952a4be938b 100644
--- a/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
+++ b/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
@@ -54,6 +54,12 @@ properties:
       - const: qspi_en
       - const: qspi

+  fsl,qspi-sampling-delay:
+ description: delay sampling of incoming data by this number of half cycles

Use the common rx-sample-delay-ns property.

+    minimum: 0
+    maximum: 3
+    default: 0
+
 required:
   - compatible
   - reg
--
2.34.1




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux