Re: [PATCH] spi: pl022: Only use DT-specified DMA channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Vincent,

On 02/01/23 21:38, Vincent Whitchurch wrote:
When a platform is booted with devicetree and does not provide a
platform data structure, the driver creates one internally.  enable_dma
should not be set in this structure when creating it; the probe function
will set it later if DMA channels are specified via the devicetree.

Yeah, I agree.


Setting enable_dma = 1 when creating this internal platform data can
lead to pl022_dma_probe() finding bogus DMA channels (since there is no
channel filter specified) when no DMA channels are specified in the
devicetree.

Signed-off-by: Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>
---

Acked-by: Dhruva Gole <d-gole@xxxxxx>

  drivers/spi/spi-pl022.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index e4484ace584e..a17ff839117f 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -2091,7 +2091,6 @@ pl022_platform_data_dt_get(struct device *dev)
  		return NULL;
pd->bus_id = -1;
-	pd->enable_dma = 1;
  	of_property_read_u32(np, "pl022,autosuspend-delay",
  			     &pd->autosuspend_delay);
  	pd->rt = of_property_read_bool(np, "pl022,rt");

--
Thanks and Regards,
Dhruva Gole



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux