Re: [PATCH v3 2/2] spi: Add Socionext F_OSPI SPI flash controller driver

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Hayashi-san,

On Wed, Nov 30, 2022 at 1:47 AM Kunihiko Hayashi
<hayashi.kunihiko@xxxxxxxxxxxxx> wrote:
> On 2022/11/30 1:49, Geert Uytterhoeven wrote:
> > On Thu, Nov 24, 2022 at 1:36 AM Kunihiko Hayashi
> > <hayashi.kunihiko@xxxxxxxxxxxxx> wrote:
> >> Introduce Socionext F_OSPI controller driver. This controller is used to
> >> communicate with slave devices such as SPI Flash memories. It supports
> >> 4 slave devices and up to 8-bit wide bus, but supports master mode only.
> >>
> >> This driver uses spi-mem framework for SPI flash memory access, and
> >> can only operate indirect access mode and single data rate mode.
> >>
> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>

> >> --- a/drivers/spi/Kconfig
> >> +++ b/drivers/spi/Kconfig
> >> @@ -906,6 +906,15 @@ config SPI_SLAVE_MT27XX
> >>            say Y or M here.If you are not sure, say N.
> >>            SPI slave drivers for Mediatek MT27XX series ARM SoCs.
> >>
> >> +config SPI_SN_F_OSPI
> >> +       tristate "Socionext F_OSPI SPI flash controller"
> >> +       depends on OF && HAS_IOMEM
> >> +       depends on SPI_MEM
> >
> > On which systems is this hardware block found?
> > Perhaps this should depend on ARCH_UNIPHIER || COMPILE_TEST?
>
> This IP doesn't depend on ARCH_UNIPHIER, so I expect that it can be widely
> applied not only to ARCH_UNIPHIER.

OK.

> If COMPILE_TEST is required, the dependency is like SPI_CADENCE_XSPI:
>          depends on (OF || COMPILE_TEST) && HAS_IOMEM

While this is not a hard requirement, it would be nice to have.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds