On Mon, Oct 17, 2022 at 08:41:24PM +0300, Andy Shevchenko wrote: > On Mon, Oct 17, 2022 at 06:39:19PM +0100, Mark Brown wrote: > > Which board code is this? The names of the new properties you're adding > > is really not at all idiomatic for ACPI and this is pretty old code so > > it's surprising that there's not existing systems that don't have this > > in their BIOSs. > drivers/mfd/intel-lpss-pci.c. OK, so this is another push for device properties for passing stuff internally. Please resubmit this series with descriptions of why this is being done - I really can't tell what the benefit is here in concrete terms, you say it somehow improves identification of which variant is in use but don't articulate specifically why. You should probably also restructure the code interpreting the device IDs so that it's very clear that unknown values are handled well, this would split things between multiple subsystems and right now the code is a bit fragile.
Attachment:
signature.asc
Description: PGP signature
