Re: [PATCH 1/3] dt-bindings: arm: airoha: Add documentation for Airoha SPI controller

[Rob Herring <robh@xxxxxxxxxx>]

On Thu, Sep 22, 2022 at 12:04:08PM +0200, Bert Vermeulen wrote:
> Create documentation for accessing the Airoha EN7523 SPI controller.
> 
> Signed-off-by: Bert Vermeulen <bert@xxxxxxxx>
> ---
>  .../bindings/spi/airoha,en7523-spi.yaml       | 54 +++++++++++++++++++
>  1 file changed, 54 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml
> 
> diff --git a/Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml b/Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml
> new file mode 100644
> index 000000000000..e5bc7814424e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/airoha,en7523-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Airoha EN7523 SPI controller
> +
> +maintainers:
> +  - Bert Vermeulen <bert@xxxxxxxx>
> +
> +description: |
> +  This binding describes the SPI controller on Airoha EN7523 SoCs.
> +
> +allOf:
> +  - $ref: "spi-controller.yaml#"

Drop quotes.

> +
> +properties:
> +  compatible:
> +    items:
> +      - const: airoha,en7523-spi
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: SPI clock

'maxItems: 1' is sufficient.

> +
> +  clock-names:
> +    items:
> +      - const: spi

You don't really need clock-names when there is only 1.

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - '#address-cells'
> +  - '#size-cells'
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/en7523-clk.h>
> +    spi0: spi@1fa10000 {
> +      compatible = "airoha,en7523-spi";
> +      reg = <0x1fa10000 0x10000>;
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      clocks = <&scu EN7523_CLK_SPI>;
> +      clock-names = "spi";
> +    };
> -- 
> 2.25.1
> 
>