On Fri, Sep 23, 2022 at 02:32:42PM +0800, Yang Yingliang wrote: > On 2022/9/23 13:55, Lukas Wunner wrote: > > On Sat, Sep 17, 2022 at 08:26:39PM +0800, Yang Yingliang wrote: > > > Add devm_spi_alloc_master() and devm_spi_alloc_slave() to devres.rst. > > > They are introduced by commit 5e844cc37a5c ("spi: Introduce device-managed > > > SPI controller allocation"). > > > > > > Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx> > > > --- > > > Documentation/driver-api/driver-model/devres.rst | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst > > > index 76cc256c9e4f..1bd6f38dd7e3 100644 > > > --- a/Documentation/driver-api/driver-model/devres.rst > > > +++ b/Documentation/driver-api/driver-model/devres.rst > > > @@ -437,6 +437,8 @@ SLAVE DMA ENGINE > > > SPI > > > devm_spi_register_master() > > > + devm_spi_alloc_master() > > > + devm_spi_alloc_slave() > > > WATCHDOG > > > devm_watchdog_register_device() > > Putting the alloc functions above the register function would > > probably be more in line with how they're used. Apart from that: > > Do I need send a v2 to move up alloc functions with your review tag. I'm not seeing v1 of your patch in linux-next, so apparently it hasn't been applied yet. So yes, if you could respin that would be great. Please cc me both on this patch as well as any devm_spi_alloc_master() conversions you make. Thanks, Lukas