On Tue, Sep 20, 2022 at 09:48:14PM +0800, Yang Yingliang wrote: > Switch to use devm_spi_alloc_master() to simpify error path. That's not sufficient. You also need to remove the call to spi_master_put() from tiny_spi_remove(), lest you introduce a use-after-free. Thanks, Lukas
Re: [PATCH -next 1/6] spi: oc-tiny: Switch to use devm_spi_alloc_master()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH -next 1/6] spi: oc-tiny: Switch to use devm_spi_alloc_master()
- From: Lukas Wunner <lukas@xxxxxxxxx>
- Date: Fri, 23 Sep 2022 06:55:07 +0200
- Cc: linux-spi@xxxxxxxxxxxxxxx, broonie@xxxxxxxxxx
- In-reply-to: <20220920134819.2981033-2-yangyingliang@huawei.com>
- References: <20220920134819.2981033-1-yangyingliang@huawei.com> <20220920134819.2981033-2-yangyingliang@huawei.com>
- User-agent: Mutt/1.10.1 (2018-07-13)
- References:
- [PATCH -next 0/6] spi: Switch to use devm_spi_alloc_master() in some drivers
- From: Yang Yingliang
- [PATCH -next 1/6] spi: oc-tiny: Switch to use devm_spi_alloc_master()
- From: Yang Yingliang
- [PATCH -next 0/6] spi: Switch to use devm_spi_alloc_master() in some drivers
- Prev by Date: [PATCH] spi: spi-mpc52xx: switch to using gpiod API
- Next by Date: Re: [PATCH -next 2/6] spi: ath79: Switch to use devm_spi_alloc_master()
- Previous by thread: [PATCH -next 1/6] spi: oc-tiny: Switch to use devm_spi_alloc_master()
- Next by thread: Re: [PATCH -next 0/6] spi: Switch to use devm_spi_alloc_master() in some drivers
- Index(es):
 |