Re: [PATCH -next] spi: xtensa-xtfpga: Switch to use devm_spi_alloc_master()

[Max Filippov <jcmvbkbc@xxxxxxxxx>]

On Tue, Sep 20, 2022 at 11:18 PM Yang Yingliang
<yangyingliang@xxxxxxxxxx> wrote:
> On 2022/9/21 11:53, Max Filippov wrote:
> > On Tue, Sep 20, 2022 at 4:37 AM Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
> >>   static int xtfpga_spi_remove(struct platform_device *pdev)
> > There's a call to spi_master_put in the xtfpga_spi_remove,
> > IIUC this call must be dropped too.
> It can not be dropped, the controller is get in spi_bitbang_start(), it
> need be put in remove().

Oh, I see, spi_bitbang_stop doesn't do it for controllers allocated with devres.

Tested-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
Acked-by: Max Filippov <jcmvbkbc@xxxxxxxxx>

-- 
Thanks.
-- Max