Re: [PATCH -next] spi: s3c24xx: Switch to use devm_spi_alloc_master()

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 20/09/2022 13:49, Yang Yingliang wrote:
(...)

>  
>  	s3c24xx_spi_initialsetup(hw);
> @@ -531,17 +525,11 @@ static int s3c24xx_spi_probe(struct platform_device *pdev)
>  	err = spi_bitbang_start(&hw->bitbang);
>  	if (err) {
>  		dev_err(&pdev->dev, "Failed to register SPI master\n");
> -		goto err_register;
> +		clk_disable(hw->clk);
> +		return err;
>  	}
>  
>  	return 0;
> -
> - err_register:
> -	clk_disable(hw->clk);

This label and error handling should rather stay.


Best regards,
Krzysztof