On Thu, Sep 08, 2022 at 11:29:22AM +0200, Hans de Goede wrote: > On 9/7/22 18:46, Andy Shevchenko wrote: ... > > + long ret; > > "long ret" should be "int ret" here since that is what acpi_dev_uid_to_integer() > returns. I put it long since the efi_get_device_by_path() uses long ret (for the sake of consistency with the existing code), but I have no objections to move it to int. -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 8/8] efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v1 8/8] efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer()
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Thu, 8 Sep 2022 13:04:55 +0300
- Cc: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>, linux-acpi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-efi@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, devel@xxxxxxxxxx, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Ard Biesheuvel <ardb@xxxxxxxxxx>, Elie Morisse <syniurge@xxxxxxxxx>, Nehal Shah <nehal-bakulchandra.shah@xxxxxxx>, Shyam Sundar S K <shyam-sundar.s-k@xxxxxxx>, Khalil Blaiech <kblaiech@xxxxxxxxxx>, Andy Gross <agross@xxxxxxxxxx>, Bjorn Andersson <andersson@xxxxxxxxxx>, Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Daniel Mack <daniel@xxxxxxxxxx>, Haojian Zhuang <haojian.zhuang@xxxxxxxxx>, Robert Jarzmik <robert.jarzmik@xxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Robert Moore <robert.moore@xxxxxxxxx>, Wolfram Sang <wsa@xxxxxxxxxx>
- In-reply-to: <72acff59-81f0-f466-6197-d3e993f051ac@redhat.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20220907164606.65742-1-andriy.shevchenko@linux.intel.com> <20220907164606.65742-9-andriy.shevchenko@linux.intel.com> <72acff59-81f0-f466-6197-d3e993f051ac@redhat.com>
- References:
- [PATCH v1 0/8] ACPI: unify _UID handling as integer
- From: Andy Shevchenko
- [PATCH v1 8/8] efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer()
- From: Andy Shevchenko
- Re: [PATCH v1 8/8] efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer()
- From: Hans de Goede
- [PATCH v1 0/8] ACPI: unify _UID handling as integer
- Prev by Date: Re: [PATCH v1 8/8] efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer()
- Next by Date: Re: [PATCH v1 8/8] efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer()
- Previous by thread: Re: [PATCH v1 8/8] efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer()
- Next by thread: Re: [PATCH v1 0/8] ACPI: unify _UID handling as integer
- Index(es):
 |