Re: [PATCH v1 1/2] spi: stm32-qspi: Replace of_gpio_named_count() by gpiod_count()

[Patrice CHOTARD <patrice.chotard@xxxxxxxxxxx>]

Hi Andy

On 8/30/22 20:28, Andy Shevchenko wrote:
> As a preparation to unexport of_gpio_named_count(), convert the
> driver to use gpiod_count() instead.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/spi/spi-stm32-qspi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c
> index 227f450aa5f0..5858f5f9c758 100644
> --- a/drivers/spi/spi-stm32-qspi.c
> +++ b/drivers/spi/spi-stm32-qspi.c
> @@ -656,7 +656,7 @@ static int stm32_qspi_setup(struct spi_device *spi)
>  	mode = spi->mode & (SPI_TX_OCTAL | SPI_RX_OCTAL);
>  	if ((mode == SPI_TX_OCTAL || mode == SPI_RX_OCTAL) ||
>  	    ((mode == (SPI_TX_OCTAL | SPI_RX_OCTAL)) &&
> -	    of_gpio_named_count(qspi->dev->of_node, "cs-gpios") == -ENOENT)) {
> +	    gpiod_count(qspi->dev, "cs") == -ENOENT)) {
>  		dev_err(qspi->dev, "spi-rx-bus-width\\/spi-tx-bus-width\\/cs-gpios\n");
>  		dev_err(qspi->dev, "configuration not supported\n");
>  
> @@ -681,7 +681,7 @@ static int stm32_qspi_setup(struct spi_device *spi)
>  	 * are both set in spi->mode and "cs-gpios" properties is found in DT
>  	 */
>  	if (((spi->mode & (SPI_TX_OCTAL | SPI_RX_OCTAL)) == (SPI_TX_OCTAL | SPI_RX_OCTAL)) &&
> -	    of_gpio_named_count(qspi->dev->of_node, "cs-gpios")) {
> +	    gpiod_count(qspi->dev, "cs")) {
>  		qspi->cr_reg |= CR_DFM;
>  		dev_dbg(qspi->dev, "Dual flash mode enable");
>  	}

Reviewed-by: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>

Thanks
Patrice