Hi Mark On 8/22/22 18:50, Mark Brown wrote: > On Mon, Aug 22, 2022 at 06:21:16PM +0200, Patrice CHOTARD wrote: >> Hi Mark >> >> I just noticed that the cleanup() callback is useless as the gpiod is >> automatically freed by devm. >> >> As you haven't send your pull request, do you accept a fixup patch you will squash >> with patch [2/2] "spi: stm32_qspi: Add transfer_one_message() spi callback" >> or standalone patch ? > > Normally you should just send an incremental patch but since it was the > top commit of the branch and I only just pushed it I've dropped this > commit (b051161f44d414e736fa2b011245441bae9babd7) so you can resend > with the fix squashed in if you want. I have resubmited the patch with the fix squashed in : https://lore.kernel.org/linux-spi/20220823075850.575043-1-patrice.chotard@xxxxxxxxxxx/T/#t Thanks Patrice