Hi Jian Zhang, On Sun, 1 May 2022, at 20:26, Jian Zhang wrote: > Implement the flash toggle function in soc ast2600. > Add two sysfs attrs named "access_primary" and "access_backup" If you're proposing this patch for upstream then it needs to be based on an upstream kernel tree, not the OpenBMC kernel tree. You also should not use e.g. `linux dev-5.15` in the patch subject prefix, as that would be inappropriate for an upstream patch. As you're adding sysfs attributes you'll also need to add the corresponding ABI documentation. Cheers, Andrew