On Tue, Jul 19, 2022 at 09:55:15AM +0200, Marc Kleine-Budde wrote: > The difference is (Jens Lindahl): > > + if (bs->tx_dma_active) { > + dmaengine_terminate_sync(ctlr->dma_tx); > + bs->tx_dma_active = false; > + } > > vs. (me): > > + if (ctlr->dma_tx) { > + dmaengine_terminate_sync(ctlr->dma_tx); > + bs->tx_dma_active = false; > + } > > Which one is preferred? Probably checking dma_tx is a bit more robust, though it shouldn't matter really.
Attachment:
signature.asc
Description: PGP signature