Re: [PATCH next 1/1] spi: sifive: add PM callbacks to support suspend/resume

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Fri, Jun 10, 2022 at 10:05 AM Andy Chiu <andy.chiu@xxxxxxxxxx> wrote:
>

Missed changelog.

> Signed-off-by: Andy Chiu <andy.chiu@xxxxxxxxxx>
> Reviewed-by: Greentime Hu <greentime.hu@xxxxxxxxxx>

>         .driver = {
>                 .name = SIFIVE_SPI_DRIVER_NAME,
> +               .pm = &sifive_spi_pm_ops,

Missed pm_sleep_ptr(). Have you compiled it with CONFIG_PM_SLEEP=n?
Have you got warnings of unused functions?

>                 .of_match_table = sifive_spi_of_match,
>         },

-- 
With Best Regards,
Andy Shevchenko