On 09/06/2022 11:55, Mark Brown wrote: > On Thu, Jun 09, 2022 at 01:55:33PM +0800, Yang Li wrote: >> The function platform_get_irq() never returns 0, and the print function >> dev_err() is redundant because platform_get_irq() already prints an error. > > Are you sure it never returns 0? Note that 0 is a valid IRQ number on > some architectures. If anything, I think I need to go in the other direction and make sure that in my i2c and pwm drivers I also check for zero - it's an FPGA after all. Thanks, Conor.