On Tue, May 24, 2022 at 08:25:06AM +0200, David Jander wrote: > Andrew Lunn <andrew@xxxxxxx> wrote: > > On Mon, May 23, 2022 at 04:20:09PM +0200, David Jander wrote: > > > .attr = { .name = file, .mode = 0444 }, \ > > Not a criticism of this patch, but this is the old way to do this. It > > is better to use DEVICE_ATTR_RO(), but that is a bigger rework. > I suppose it is better to do this in a separate patch? @Mark, should I leave > it as is, or do you require a "modernization" for this first? I'd do it as a followup to this patch, that's just a random cleanup.
Attachment:
signature.asc
Description: PGP signature