On Mon, May 23, 2022 at 05:13:16PM +0200, Andrew Lunn wrote: > On Mon, May 23, 2022 at 04:20:09PM +0200, David Jander wrote: > > + inc = u64_stats_read(&pcpu_stats->field); \ > > + } while (u64_stats_fetch_retry_irq( \ > > + &pcpu_stats->syncp, start)); \ > > + ret += inc; \ > > + } \ > > +} while (0) > Looking at this from the perspective of a network reviewer, that is a > pretty big macro. netdev would probably not allow this. But macro > magic does seem normal in this file. Yes, it's following the existing idiom so it's fine. I didn't see any issues Andrew didn't already mention, otherwise it looks pretty good to me - it's a nice clean change for the performance improvement.
Attachment:
signature.asc
Description: PGP signature
