Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Mon, Aug 23, 2021 at 1:59 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> CC sergey's new address
>
> On Wed, Aug 18, 2021 at 10:57 AM Zhengxun <zhengxunli.mxic@xxxxxxxxx> wrote:
> > In the RPC manual mode, if the data direction is not set
> > (such as the flash erase command), the address misses the
> > setting.
> >
> > Signed-off-by: Zhengxun <zhengxunli.mxic@xxxxxxxxx>
> > ---
> >  drivers/memory/renesas-rpc-if.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
> > index 45eed659b0c6..9dd27c6307f7 100644
> > --- a/drivers/memory/renesas-rpc-if.c
> > +++ b/drivers/memory/renesas-rpc-if.c
> > @@ -482,6 +482,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
> >                 }
> >                 break;
> >         default:
> > +               regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
> >                 regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
> >                 regmap_write(rpc->regmap, RPCIF_SMCR,
> >                              rpc->smcr | RPCIF_SMCR_SPIE);

This patch never received review comments.
As of commit fff53a551db50f5e ("memory: renesas-rpc-if: Correct QSPI
data transfer in Manual mode") in v5.16-rc1, RPCIF_SMADR is written
before the switch() statement, hence this patch can be ignored.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds