[Q] Should direct access mode be enabled for intel,socfpga-qspi?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi linux-spi folks,

Upstream commit 98d948eb8331 ("spi: cadence-quadspi: fix write completion support") introduced the "intel,socfpga-qspi" compatible string and the new CQSPI_NO_SUPPORT_WR_COMPLETION quirk.

Changing the device tree node's "compatible" string from "cdns,qspi-nor" to "intel,socfpga-qspi" sets CQSPI_NO_SUPPORT_WR_COMPLETION but no longer sets CQSPI_DISABLE_DAC_MODE. I'm guessing that was unintentional and that quirks should have both bits set.

"socfpga.dtsi" sets the size of the AHB resource to 0x1000, so direct mode would only be used for the initial 4 KiB. "socfpga-arria10" and "socfpga-stratix10.dtsi" set the size of the AHB resource to 0x100000, so direct mode would be used for the initial 1 MiB (usually the whole flash device).

Can anyone confirm whether DAC mode should be used or not on socfpga?

Thanks,
Ian

--
-=( Ian Abbott <abbotti@xxxxxxxxx> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux