Re: [PATCH v2] spi: spi-mem: check if data buffers are on stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 20, 2022 at 03:50:22PM +0530, Pratyush Yadav wrote:
> The buffers passed in the data phase must be DMA-able. Programmers often
> don't realise this requirement and pass in buffers that reside on the
> stack. This can be hard to spot when reviewing code. Reject ops if their
> data buffer is on the stack to avoid this.
> 
> Signed-off-by: Pratyush Yadav <p.yadav@xxxxxx>
> Acked-by: Mark Brown <broonie@xxxxxxxxxx>
> ---
> 
> Changes in v2:
> - Include task_stack.h. It might not get included indirectly on some
>   platforms and can cause build failures.
> - Add a WARN_ON_ONCE() for debuggability.
> - Add Mark's Ack.

Since this is now an isolated patch does that mean whatever meant that I
acked rather than applying this patch has gone in and I can now apply it
directly?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux