RE: [PATCH v4 0/3] Add support for Intel Thunder Bay SPI controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

Kindly help to review the patch set "Add support for Intel Thunder Bay SPI controller".

Regards,
Nandhini 

> -----Original Message-----
> From: Srikandan, Nandhini <nandhini.srikandan@xxxxxxxxx>
> Sent: Tuesday, March 8, 2022 4:03 PM
> To: fancer.lancer@xxxxxxxxx; broonie@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
> linux-spi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx; mgross@xxxxxxxxxxxxxxx; Pan, Kris
> <kris.pan@xxxxxxxxx>; Demakkanavar, Kenchappa
> <kenchappa.demakkanavar@xxxxxxxxx>; Zhou, Furong
> <furong.zhou@xxxxxxxxx>; Sangannavar, Mallikarjunappa
> <mallikarjunappa.sangannavar@xxxxxxxxx>; Vaidya, Mahesh R
> <mahesh.r.vaidya@xxxxxxxxx>; Srikandan, Nandhini
> <nandhini.srikandan@xxxxxxxxx>; A, Rashmi <rashmi.a@xxxxxxxxx>
> Subject: [PATCH v4 0/3] Add support for Intel Thunder Bay SPI controller
> 
> From: Nandhini Srikandan <nandhini.srikandan@xxxxxxxxx>
> 
> Hi,
> 
> This patch enables support for DW SPI on Intel Thunder Bay (patch 1,2).
> This patch set also enables master mode for latest Designware SPI versions
> (patch 3).
> 
> Patch 1: DW SPI DT bindings for Intel Thunder Bay SoC.
> Patch 2: Adds support for Designware SPI on Intel Thunderbay SoC.
> Patch 3: Adds master mode support for Designware SPI controller.
> 
> The driver is tested on Keem Bay and Thunder Bay evaluation board
> 
> Summary:
> Changes from v3:
> 1) Dropped SSTE support in this patch.
> 2) Rebased to the latest code.
> 
> Changes from v2:
> 1) SSTE support made using dt and created seperate patches.
> 2) SPI controller master mode selection made common to all DW SPI
> controllers.
> 3) Using a common init function for both keem bay and thunder bay.
> 
> Changes from v1:
> 1) Designware CR0 specific macros are named in a generic way.
> 2) SPI CAP macros are named in generic way rather than naming project
> specific.
> 3) SPI KEEM BAY specific macros are replaced by generic macros.
> 4) Resued the existing SPI deassert API instead of adding another reset
> 
> 
> Changes in patches:
> Patch 1:
> Changes from v3/v2/v1:
> 1) No change in this patch
> 
> Patch 2:
> Changes from v3:
> 1) No changes.
> 
> Changes from v2:
> 1) Init function is made common for Keem Bay and Thunder Bay.
> 
> Patch 3:
> Changes from v3:
> 1) Corrected dw_spi_ip_is macro with the missing underscore.
> 2) Setting CTRLR0 BIT31 without any condition check as in older version of
>    DW SPI controller this bit is reserved.
> 
> Changes from v2/v1:
> 1)Newly introduced in v3 to make master mode selection as seperate patch
> 
> Thanks & Regards,
> Nandhini
> 
> 
> Nandhini Srikandan (3):
>   dt-bindings: spi: Add bindings for Intel Thunder Bay SoC
>   spi: dw: Add support for Intel Thunder Bay SPI controller
>   spi: dw: Add support for master mode selection for DWC SSI controller
> 
>  .../devicetree/bindings/spi/snps,dw-apb-ssi.yaml          | 2 ++
>  drivers/spi/spi-dw-core.c                                 | 4 ++--
>  drivers/spi/spi-dw-mmio.c                                 | 8 ++++----
>  drivers/spi/spi-dw.h                                      | 7 +++----
>  4 files changed, 11 insertions(+), 10 deletions(-)
> 
> --
> 2.17.1





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux