Re: [PATCH] spi: dw: assert reset before deasserting reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 11, 2022 at 03:51:23PM +0000, Niklas Cassel wrote:

> I think it is a good to start off with all registers in their
> default reset values.

> Arguably, I think it looks wrong to see a reset_control_deassert()
> without any previous reset_control_assert().

I do tend to agree that if we've got the ability to do a reset it's good
practice to use it to get the hardware into a known state, it just
guards against the possibility that there's some system or configuration
where things are left in a surprising state which ends up causing
problems.  Unless the reset is going to take a long time there should be
no real downside even if the upside is marginal.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux