Re: [PATCH v2 1/2] dt-bindings: spi: Update clocks property for ARM pl022

[Kuldeep Singh <singh.kuldeep87k@xxxxxxxxx>]

On Tue, Mar 08, 2022 at 09:27:48AM +0100, Krzysztof Kozlowski wrote:
> On 08/03/2022 08:21, Kuldeep Singh wrote:
> > Add missing minItems property to clocks in ARM pl022 bindings.
> > 
> > This helps in resolving below warnings:
> > clocks: [[4]] is too short
> > clock-names: ['apb_pclk'] is too short
> > 
> > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@xxxxxxxxx>
> > ---
> > v2:
> > - Keep actual warning and remove path to file
> > - Reword commit message a bit
> 
> It still misses information whether it is actually correct from PL022
> point of view to have just one clock.
> 
> If the DTS are wrong, do not change the bindings to match such wrong
> DTS. If the DTS is correct, please explain why bindings are wrong.
 
Thanks Krzysztof for pointing it out.
So far I was wondering spiclk clock-name was the only culprit there and
had different perception w.r.t number of clocks.

Anyway, below reference is from pl022 point of view:
https://documentation-service.arm.com/static/5e8e3bc7fd977155116a936d?token=
https://developer.arm.com/documentation/ddi0194/h/functional-overview/primecell-ssp-operation/clock-ratios

The reference no where mention that single clock can exist.
So far Amd seattle and LG platforms don't comply with binding and define
single clock which require updations.

So now from bindings perspective, I am looking forward to keep only one
notation of sspclk and will respin a patch. Kindly provide comments on
the same.

Regards
Kuldeep

> > 
> >  Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> > index 6d633728fc2b..7d36e15db5b3 100644
> > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> > @@ -34,6 +34,7 @@ properties:
> >      maxItems: 1
> >  
> >    clocks:
> > +    minItems: 1
> >      maxItems: 2
> 
> This does not match clock-names which requires two clocks. It's not
> correct now.
> 
> >  
> >    clock-names:
> 
> 
> Best regards,
> Krzysztof