On 23/02/2022 21:04, Mark Brown wrote: > On Wed, Feb 23, 2022 at 08:14:37PM +0100, Krzysztof Kozlowski wrote: > >> Remove also "const" from the definition of spi_device.driver_override, >> because it is not correct. The SPI driver already treats it as >> dynamic, not const, memory. > > We don't modify the string do we, we just allocate a new one? Actually you're right - the SPI and VDPA implementations operate on "const char *". The others do not, so I can convert them to "const char *". Thanks! Best regards, Krzysztof
Re: [PATCH v2 07/11] spi: use helper for safer setting of driver_override
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 07/11] spi: use helper for safer setting of driver_override
- From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
- Date: Wed, 23 Feb 2022 21:13:07 +0100
- Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Stuart Yoder <stuyoder@xxxxxxxxx>, Laurentiu Tudor <laurentiu.tudor@xxxxxxx>, Abel Vesa <abel.vesa@xxxxxxx>, Shawn Guo <shawnguo@xxxxxxxxxx>, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, Fabio Estevam <festevam@xxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>, Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, Andy Gross <agross@xxxxxxxxxx>, Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-clk@xxxxxxxxxxxxxxx, NXP Linux Team <linux-imx@xxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-remoteproc@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
- In-reply-to: <YhaTWiSQl6pTVxqC@sirena.org.uk>
- References: <20220223191310.347669-1-krzysztof.kozlowski@canonical.com> <20220223191441.348109-1-krzysztof.kozlowski@canonical.com> <YhaTWiSQl6pTVxqC@sirena.org.uk>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0
- References:
- [PATCH v2 00/11] Fix broken usage of driver_override (and kfree of static memory)
- From: Krzysztof Kozlowski
- [PATCH v2 07/11] spi: use helper for safer setting of driver_override
- From: Krzysztof Kozlowski
- Re: [PATCH v2 07/11] spi: use helper for safer setting of driver_override
- From: Mark Brown
- [PATCH v2 00/11] Fix broken usage of driver_override (and kfree of static memory)
- Prev by Date: Re: [PATCH] spi: add missing pci_dev_put() before return
- Next by Date: Re: [PATCH v3 4/5] auxdisplay: add support for Titanmec TM1628 7 segment display controller
- Previous by thread: Re: [PATCH v2 07/11] spi: use helper for safer setting of driver_override
- Next by thread: [PATCH v2 11/11] rpmsg: fix kfree() of static memory on setting driver_override
- Index(es):
 |