Re: [PATCH v2 4/6] docs: ABI: document tm1628 attribute display-text

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Heiner,

On Mon, Feb 21, 2022 at 9:26 PM Heiner Kallweit <hkallweit1@xxxxxxxxx> wrote:
> Document the attribute for reading / writing the text to be displayed on
> the 7 segment display.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>

Thanks for your patch!

> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-devices-auxdisplay-tm1628
> @@ -0,0 +1,7 @@
> +What:          /sys/devices/.../display-text
> +Date:          February 2022
> +Contact:       Heiner Kallweit <hkallweit1@xxxxxxxxx>
> +Description:
> +               The text to be displayed on the 7 segment display.
> +               Any printable character is allowed as input, but some
> +               can not be displayed in a readable way with 7 segments.

Hence you may want to make the mapping configurable, cfr.
MAP_TO_SEG7_SYSFS_FILE in include/uapi/linux/map_to_7segment.h?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds