Re: [PATCH] spi: Fix warning for Clang build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2/10/22 7:32 PM, Lh Kuo 郭力豪 wrote:
The return here means that the initialization is now redundant and will stop the compiler spotting any
future similar issues which isn't ideal.
I got it, so do I need to submit a new patch?

Assuming yes, so something else..

Looking again at the function, there are 3 sets of if-check blocks these could be combined into the first one.

The later two are variations on is this an rx or a tx, the first check does that.

T







[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux