RE: [PATCH v6 1/2] spi: Add spi driver for Sunplus SP7021

[Lh Kuo 郭力豪 <lh.Kuo@xxxxxxxxxxx>]

Hi Mr. Mark Brown :

Thanks for your comment, I will modify it in next next submission

> 
> > +	for (i = 0; i <= xfer_cnt; i++) {
> > +		mutex_lock(&pspim->buf_lock);
> 
> This lock is redundant: it is only ever held in this function which is guaranteed by the core to never be
> called twice concurrently.

I will modify it in next next submission


> > +	ret = devm_request_irq(dev, pspim->m_irq, sp7021_spi_master_irq,
> > +			       IRQF_TRIGGER_RISING, pdev->name, pspim);
> > +	if (ret)
> > +		return ret;
> > +
> > +	ret = devm_request_irq(dev, pspim->s_irq, sp7021_spi_slave_irq,
> > +			       IRQF_TRIGGER_RISING, pdev->name, pspim);
> > +	if (ret)
> > +		return ret;
> 
> Are you sure the driver is ready to handle interrupts without any of the other resources?  Normally
> interrupts are one of the last things to be requested.

I will modify it in next next submission