Re: [PATCH] spi: s3c64xx: Convert to use GPIO descriptors

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>]

On 18/01/2022 03:33, Linus Walleij wrote:
> Convert the S3C64xx SPI host to use GPIO descriptors.
> 
> In the process we tear out some unused code in the machine,
> such as the unused config options for SPI controller 1 and
> 2. New systems should use the device tree boot to enable these
> SPI hosts.
> 
> We drop the ability to pass a custom pin config function
> to the device while registering since nothing was using this.
> 
> Provide GPIO descriptor tables for the one user with CS
> 0 and 1.
> 
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> Cc: Sylwester Nawrocki <snawrocki@xxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
>  arch/arm/mach-s3c/Kconfig                 | 12 ----
>  arch/arm/mach-s3c/devs.c                  | 77 +----------------------
>  arch/arm/mach-s3c/mach-crag6410-module.c  | 13 ----
>  arch/arm/mach-s3c/mach-crag6410.c         | 13 +++-
>  arch/arm/mach-s3c/setup-spi-s3c64xx.c     |  9 ---
>  arch/arm/mach-s3c/spi-core-s3c24xx.h      |  6 --
>  drivers/spi/spi-s3c64xx.c                 | 50 ++++-----------
>  include/linux/platform_data/spi-s3c64xx.h | 16 +----
>  8 files changed, 27 insertions(+), 169 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c/Kconfig b/arch/arm/mach-s3c/Kconfig
> index 25606e668cf9..1899fc3f44fd 100644
> --- a/arch/arm/mach-s3c/Kconfig
> +++ b/arch/arm/mach-s3c/Kconfig
> @@ -191,18 +191,6 @@ config S3C64XX_DEV_SPI0
>  	  Compile in platform device definitions for S3C64XX's type
>  	  SPI controller 0
>  
> -config S3C64XX_DEV_SPI1
> -	bool
> -	help
> -	  Compile in platform device definitions for S3C64XX's type
> -	  SPI controller 1
> -
> -config S3C64XX_DEV_SPI2
> -	bool
> -	help
> -	  Compile in platform device definitions for S3C64XX's type
> -	  SPI controller 2
> -
>  config SAMSUNG_DEV_TS
>  	bool
>  	help

Looks good to me, but I would prefer to split the dead code removal
(S3C64XX_DEV_SPI1 and S3C64XX_DEV_SPI2) from actual conversion. Such
split should be doable and would make it much easier to see actual
conversion.


Best regards,
Krzysztof