Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary)
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary)
- From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
- Date: Sun, 16 Jan 2022 15:19:06 +0100
- Cc: Sergey Shtylyov <s.shtylyov@xxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Andrew Lunn <andrew@xxxxxxx>, Ulf Hansson <ulf.hansson@xxxxxxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, linux-iio@xxxxxxxxxxxxxxx, Linus Walleij <linus.walleij@xxxxxxxxxx>, Amit Kucheria <amitk@xxxxxxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Sebastian Reichel <sre@xxxxxxxxxx>, linux-phy@xxxxxxxxxxxxxxxxxxx, Thierry Reding <thierry.reding@xxxxxxxxx>, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Guenter Roeck <groeck@xxxxxxxxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, openipmi-developer@xxxxxxxxxxxxxxxxxxxxx, Saravanan Sekar <sravanhome@xxxxxxxxx>, Khuong Dinh <khuong@xxxxxxxxxxxxxxxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, Matthias Schiffer <matthias.schiffer@xxxxxxxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, Kamal Dasu <kdasu.kdev@xxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Bartosz Golaszewski <brgl@xxxxxxxx>, Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>, Kishon Vijay Abraham I <kishon@xxxxxx>, bcm-kernel-feedback-list@xxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, Jakub Kicinski <kuba@xxxxxxxxxx>, Zhang Rui <rui.zhang@xxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, platform-driver-x86@xxxxxxxxxxxxxxx, linux-pwm@xxxxxxxxxxxxxxx, John Garry <john.garry@xxxxxxxxxx>, Robert Richter <rric@xxxxxxxxxx>, Zha Qipeng <qipeng.zha@xxxxxxxxx>, Corey Minyard <minyard@xxxxxxx>, linux-pm@xxxxxxxxxxxxxxx, Peter Korsgaard <peter@xxxxxxxxxxxxx>, William Breathitt Gray <vilhelm.gray@xxxxxxxxx>, Mark Gross <markgross@xxxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Matthias Brugger <matthias.bgg@xxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Benson Leung <bleung@xxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-edac@xxxxxxxxxxxxxxx, Tony Luck <tony.luck@xxxxxxxxx>, Mun Yew Tham <mun.yew.tham@xxxxxxxxx>, Eric Auger <eric.auger@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, linux-mmc@xxxxxxxxxxxxxxx, Joakim Zhang <qiangqing.zhang@xxxxxxx>, linux-spi@xxxxxxxxxxxxxxx, linux-renesas-soc@xxxxxxxxxxxxxxx, Vinod Koul <vkoul@xxxxxxxxxx>, James Morse <james.morse@xxxxxxx>, Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>, Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx>, linux-mediatek@xxxxxxxxxxxxxxxxxxx, Brian Norris <computersforpeace@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
- In-reply-to: <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de>
- References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de>
On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-König wrote:
> A possible compromise: We can have both. We rename
> platform_get_irq_optional() to platform_get_irq_silent() (or
> platform_get_irq_silently() if this is preferred) and once all users are
> are changed (which can be done mechanically), we reintroduce a
> platform_get_irq_optional() with Sergey's suggested semantic (i.e.
> return 0 on not-found, no error message printking).
Please do not do that as anyone trying to forward-port an old driver
will miss the abi change of functionality and get confused. Make
build-breaking changes, if the way a function currently works is
changed in order to give people a chance.
thanks,
greg k-h
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|