On 04/01/22 04:31PM, Boris Brezillon wrote: > and you get to define a DTR op like that: > > struct spi_mem_op op = > SPI_MEM_OP(SPI_MEM_OP_EXT_CMD(2, 0x1234, 8, SPI_MEM_OP_DTR), > SPI_MEM_OP_ADDR(4, 0xdeadbeef, 8, SPI_MEM_OP_DTR), > SPI_MEM_OP_DATA_OUT(128, buf, 8, SPI_MEM_OP_DTR)); > > This also means we can extend the struct without having to define new macros. I like this. It would also let us easily mix-and-match the ecc parameter that Miquel is adding. -- Regards, Pratyush Yadav Texas Instruments Inc.