On Sat, 1 Jan 2022 13:12:36 +0530 Apurva Nandan <a-nandan@xxxxxx> wrote: > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index 69e06e741717..77927afcea0f 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -194,6 +194,18 @@ > SPI_MEM_OP_NO_DUMMY, \ > SPI_MEM_OP_DATA_OUT_DTR(len, buf, 8)) > > +/** > + * enum spinand_protocol - List of SPI protocols to denote the op protocol and > + * SPI NAND flash IO modes. > + */ > +enum spinand_protocol { > + SPINAND_1S_1S_1S, > + SPINAND_2S_2S_2S, > + SPINAND_4S_4S_4S, > + SPINAND_8S_8S_8S, > + SPINAND_8D_8D_8D, I'd just name those SPINAND_PROTO_<width><S or D> since what really matters is the command cycle.