On Wed, Dec 22, 2021 at 03:08:59PM -0400, Rob Herring wrote: > On Tue, Dec 21, 2021 at 06:00:57PM +0100, Miquel Raynal wrote: > > Describe two new memories modes: > > - A stacked mode when the bus is common but the address space extended > > with an additinals wires. > > - A parallel mode with parallel busses accessing parallel flashes where > > the data is spread. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > > --- > > > > Hello Rob, > > > > I know the below does not pass the tests (at least the example patch 3 > > does not pass) but I believe the issue is probably on the tooling side > > because the exact same thing with uing32-array instead is accepted. The > > problem comes from the minItems/maxItems lines. Without them, this is > > okay. The maxItems btw matches the "good enough value for now" idea. > > > > The errors I get are: > > > > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/spi-controller.yaml > > LINT Documentation/devicetree/bindings > > CHKDT Documentation/devicetree/bindings/processed-schema-examples.json > > SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json > > DTEX Documentation/devicetree/bindings/spi/spi-controller.example.dts > > DTC Documentation/devicetree/bindings/spi/spi-controller.example.dt.yaml > > CHECK Documentation/devicetree/bindings/spi/spi-controller.example.dt.yaml > > /src/Documentation/devicetree/bindings/spi/spi-controller.example.dt.yaml: spi@80010000: flash@2:stacked-memories: [[268435456, 268435456]] is too short > > From schema: /src/Documentation/devicetree/bindings/spi/spi-controller.yaml > > /src/Documentation/devicetree/bindings/spi/spi-controller.example.dt.yaml: spi@80010000: flash@2:stacked-memories: [[268435456, 268435456]] is too short > > From schema: /src/Documentation/devicetree/bindings/spi/mxs-spi.yaml > > /src/Documentation/devicetree/bindings/spi/spi-controller.example.dt.yaml: spi@80010000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'display@0', 'sensor@1', 'flash@2' were unexpected) > > From schema: /src/Documentation/devicetree/bindings/spi/mxs-spi.yaml > > /src/Documentation/devicetree/bindings/spi/spi-controller.example.dt.yaml: flash@2: stacked-memories: [[268435456, 268435456]] is too short > > From schema: /src/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > > I'm not seeing any of these. Are you up to date with dtschema? NM, I was missing a patch and now see it. It is indeed a tool problem. I'll work on a fix. Rob