On Tue, Nov 30, 2021 at 05:14:07PM +0300, Dmitry Osipenko wrote: > The ifdefery, that this patch has, shouldn't be needed. We have a > similar ACPI patch for Tegra I2C [1] and it doesn't have that. > [1] > https://patchwork.ozlabs.org/project/linux-tegra/patch/1637859224-5179-1-git-send-email-akhilrajeev@xxxxxxxxxx/ > I assume this patch could be reworked similarly to the I2C patch. Yes, that looks much cleaner. > Agree that should be better to have a common reset driver for ACPI > instead of polluting each driver with a boilerplate code. Right, I think that'd be even better. It's probably best to split adding reset support to the driver out from adding the ACPI ID - they shouldn't really have been merged in the first place TBH - and then try this approach first.
Attachment:
signature.asc
Description: PGP signature
