On 10-11-21, 10:39, Dan Carpenter wrote: > This code has several issues: > 1) It passes IS_ERR() to dev_err_probe() instead of PTR_ERR(). > 2) It always prints an error message, even when it succeeds. > 3) The "if (ret < 0) {" conditions are never true. > 4) If requesting "mas->tx" fails then it sets "mas->rx" to NULL but the > intention was to set "mas->tx" to NULL. Acked-By: Vinod Koul <vkoul@xxxxxxxxxx> -- ~Vinod