On Tue, 12 Oct 2021, Uwe Kleine-König wrote: > Up to now mc13xxx_common_exit() returns zero unconditionally. Make it > return void instead which makes it easier to see in the callers that > there is no error to handle. > > Also the return value of i2c and spi remove callbacks is ignored anyway. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > drivers/mfd/mc13xxx-core.c | 4 +--- > drivers/mfd/mc13xxx-i2c.c | 3 ++- > drivers/mfd/mc13xxx-spi.c | 3 ++- > drivers/mfd/mc13xxx.h | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH v2 08/20] mfd: mc13xxx: Make mc13xxx_common_exit() return void
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 08/20] mfd: mc13xxx: Make mc13xxx_common_exit() return void
- From: Lee Jones <lee.jones@xxxxxxxxxx>
- Date: Thu, 21 Oct 2021 11:18:58 +0100
- Cc: Mark Brown <broonie@xxxxxxxxxx>, kernel@xxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx
- In-reply-to: <20211012153945.2651412-9-u.kleine-koenig@pengutronix.de>
- References: <20211012153945.2651412-1-u.kleine-koenig@pengutronix.de> <20211012153945.2651412-9-u.kleine-koenig@pengutronix.de>
- References:
- [PATCH v2 00/20] Make some spi device drivers return zero in .remove()
- From: Uwe Kleine-König
- [PATCH v2 08/20] mfd: mc13xxx: Make mc13xxx_common_exit() return void
- From: Uwe Kleine-König
- [PATCH v2 00/20] Make some spi device drivers return zero in .remove()
- Prev by Date: Re: [PATCH 13/18] mtd: nand: mxic-ecc: Support SPI pipelined mode
- Next by Date: Re: [PATCH v2 09/20] mfd: stmpe: Make stmpe_remove() return void
- Previous by thread: [PATCH v2 08/20] mfd: mc13xxx: Make mc13xxx_common_exit() return void
- Next by thread: [PATCH v2 09/20] mfd: stmpe: Make stmpe_remove() return void
- Index(es):
 |